playground/README: Suggest gopherjs serve command. #25
Conversation
Now that gopherjs has a capable serve command built in (see gopherjs/gopherjs#121), it's better to suggest using it directly. This way there's no need to download and learn to use a separate command when this functionality is now available upstream in gopherjs itself. /cc @ajhager Also update description of what the update.sh script does. It does not pull the latest version, it simply does `go install ...gopherjs` which installs whatever version you have locally.
|
👍 |
|
Don't merge this yet. I tried it out earlier and it seemed to work, but it might've been just serving the static content instead of rebuilding from source. If that's the case, I might have to adjust the steps. |
|
Yeah, it doesn't actually rebuild/use the Thinking about how to best resolve this... |
|
I think we can resolve the issue by renaming However, I think the playground is not in a state where it can be rebuilt right now, so that needs to be resolved first before this PR can make progress. |
That has been resolved (#27), so we can make progress on this. |
|
This is currently blocking on gopherjs/gopherjs#257 being merged. After that, I think this PR is ready for review and merging also (no other changes are needed). |
|
Now that gopherjs/gopherjs#257 is merged, this is ready for review and to be merged. @neelance, if it has LGTM from you, I can merge. |
|
LGTM |
…js-serve playground/README: Suggest gopherjs serve command.
Now that
gopherjshas a capableservecommand built in (see gopherjs/gopherjs#121), it's better to suggest using it directly. This way there's no need to download and learn to use a separate command when this functionality is now available upstream in gopherjs itself. /cc @ajhagerAlso update description of what the
update.shscript does. It does not pull the latest version, it simply doesgo install ...gopherjswhich installs whatever version you have currently checked out locally.