Skip to content

Fix #18: Remove dependency on fmt #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix #18: Remove dependency on fmt #19

wants to merge 1 commit into from

Conversation

johanbrandhorst
Copy link
Contributor

Will lead to smaller generated files.

Will lead to smaller generated files.
@johanbrandhorst johanbrandhorst changed the title Remove dependency on fmt Fix #18: Remove dependency on fmt Feb 13, 2017
@flimzy
Copy link
Member

flimzy commented Feb 13, 2017

This won't help. Look at the import graph. fmt is also imported indirectly by net/url and context.

@johanbrandhorst
Copy link
Contributor Author

Ah, my mistake! I'll go ahead and close this.

@johanbrandhorst johanbrandhorst mentioned this pull request Feb 13, 2017
dmitshur pushed a commit that referenced this pull request Mar 13, 2017
The goal is to help reduce generated binary size for that only use
the low-level wrapper.

Packages net and net/url use fmt package, making it not possible to
remove the relatively large fmt dependency from the websocket package.
Package net is only used to implement the net.Conn interface.

Separate the low-level plain wrapper into a different package from
the high-level net.Conn wrapper, making it possible for users to
import only what they need at a more granular level.

Updates #18.
Updates #19.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants