Skip to content

Update v1 API #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 2, 2019
Merged

Update v1 API #2

merged 2 commits into from
Feb 2, 2019

Conversation

eternal-flame-AD
Copy link
Member

Changes induced:

  • Removed EmptyConfig()
  • Added a location parameter to GetDisplayer to that plugins can get where they can be accessed from.
  • Added an Extras property to Message
  • Added a basePath to RegisterWebhook
  • Changed gin.RouterGroup to a pointer reference

@eternal-flame-AD eternal-flame-AD mentioned this pull request Feb 2, 2019
Merged
9 tasks
jmattheis
jmattheis requested changes Feb 2, 2019
View reviewed changes
jmattheis
jmattheis approved these changes Feb 2, 2019
View reviewed changes
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll remove the v1.0.0 tag and release and then add it again to the updated plugin api right?

@jmattheis jmattheis merged commit b0e2eca into gotify:master Feb 2, 2019
@eternal-flame-AD
Copy link
Member Author

Yes.

@jmattheis jmattheis mentioned this pull request Feb 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmattheis jmattheis jmattheis approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eternal-flame-AD @jmattheis