Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(distributor): add experimental memberlist kvStore for ha_tracker #10054

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NickAnge
Copy link
Contributor

@NickAnge NickAnge commented Nov 29, 2024

What this PR does

This PR enables experimental memberlist kvStore for the ha_tracker. We can change memberlist parameters through -memberlist-* flag

Important

Setting this PR to draft until we merge #10020 and grafana/dskit#612, and we can start testing

Which issue(s) this PR fixes or relates to

Part of https://github.com/grafana/pir-actions/issues/94

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@NickAnge NickAnge force-pushed the nickange/ha_tracker/enable_memberlist_experimental branch from 2d750f1 to 3b2f0db Compare November 29, 2024 10:40
@@ -43,6 +43,7 @@
* [FEATURE] PromQL: Add experimental `info` function. Experimental functions are disabled by default, but can be enabled setting `-querier.promql-experimental-functions-enabled=true` in the query-frontend and querier. #9879
* [FEATURE] Distributor: Support promotion of OTel resource attributes to labels. #8271
* [FEATURE] Querier: Add experimental `double_exponential_smoothing` PromQL function. Experimental functions are disabled by default, but can be enabled by setting `-querier.promql-experimental-functions-enabled=true` in the query-frontend and querier. #9844
* [FEATURE] Distributor: Add experimental `memberlist` kvStore for ha_tracker. Memberlist parameters can be changed through `-memberlist-*` flags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add this in the about-versioning.md doc? It's where we list all experimental features. You can also explain briefly why it is considered experimental.

also for this entry: can you add the PR number and also mention the full config option by which they can use memberlist for the HA tracker.

@NickAnge NickAnge force-pushed the nickange/ha_tracker/enable_memberlist_experimental branch from 3b2f0db to 3b4d8c7 Compare December 2, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants