Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor update mimir-prometheus at 0a0a41616520101ffd29c38f167b36898f08019d #10203

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Vendor update mimir-prometheus at 0a0a41616520101ffd29c38f167b36898f08019d #10203

merged 2 commits into from
Dec 11, 2024

Conversation

jesusvazquez
Copy link
Member

@jesusvazquez jesusvazquez commented Dec 10, 2024 •
edited
Loading

This PR updates mimir-prometheus dependency. It brings:

There is another candidate that brings the rest of the changes here #10188 discussing with Krajo if we could combine the effort. Leaving as draft for now

  • EDIT: Just rebased now that Krajo's PR is merged

@jesusvazquez jesusvazquez mentioned this pull request Dec 10, 2024
Merged
4 tasks
@jesusvazquez jesusvazquez force-pushed the jvp/update-dependency-with-mimir-prometheus branch from c7aea53 to b983d73 Compare December 11, 2024 11:57
@jesusvazquez jesusvazquez marked this pull request as ready for review December 11, 2024 11:57
@jesusvazquez jesusvazquez requested review from stevesg, grafanabot and a team as code owners December 11, 2024 11:57
krajorama
krajorama approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@krajorama krajorama enabled auto-merge (squash) December 11, 2024 13:00
@krajorama krajorama merged commit cb7ed47 into main Dec 11, 2024
29 checks passed
@krajorama krajorama deleted the jvp/update-dependency-with-mimir-prometheus branch December 11, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krajorama krajorama krajorama approved these changes

@stevesg stevesg Awaiting requested review from stevesg stevesg is a code owner

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesusvazquez @krajorama