Add alerts #21
Add alerts #21
Conversation
| expr: ||| | ||
| avg without(pod, instance) | ||
| (rate(pg_stat_database_xact_rollback{db_name!~"template.*|^$"}[5m]) / | ||
| (rate(pg_stat_database_xact_commit{db_name!~"template.*|^$"}[5m])+ rate(pg_stat_database_xact_rollback{db_name!~"template.*|^$"}[5m]))) > 0.10 |
There was a problem hiding this comment.
Another nit here, the description has a generic "too many rollbacks", while the query is hardcoded with > 0.10
We should probably communicate to users exactly what percentage is being exceeded, and/or allow them to configure this like our other newer integrations via the config file
|
Thanks for the review @Dasomeone I need to give this PR another pass as I forgot alot of asserts variables are in there. Let me work on it and I will ping you again for review. |
|
All asserts related items are removed from the alerts. For thresholds should we make all thresholds configurable? @Dasomeone Do you suggest making them all configurable? |
No for the thresholds I'm looking for context, e.g. why they're set the way they are. A lot of them are hard to intuit, being byte values without explanation, though some of them would benefit from being configurable in the config file. Could be all if you wanted to, but mostly looking for context |
Add new alerts for postgres