Remove hack in chain_head_listener #5240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added in a time when we were having problems with receiving chain head updates and were trying workarounds. This one had a hypothesis of a deadlock in tokio Watch::send. I was never able to corroborate this, no other tokio user ever reported something like this and improvements have since been made to the internals of `Watch`. So there isn't much justification for keeping this hack.
|
I tried this on a canary build in studio and it resolved some of the |
lutter
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in a time when we were having problems with receiving chain head updates and were trying workarounds. This one had a hypothesis of a deadlock in tokio Watch::send. I was never able to corroborate this, no other tokio user ever reported something like this and improvements have since been made to the internals of
Watch. So there isn't much justification for keeping this hack.