Skip to content

Support Indexed argument filtering #5254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 22, 2024
Merged

Support Indexed argument filtering #5254

merged 16 commits into from
Apr 22, 2024

Conversation

incrypto32
Copy link
Member

Closes #2052

@incrypto32
Copy link
Member Author

The large diff is the yarn.lock file for the intgration tests

@incrypto32 incrypto32 self-assigned this Mar 4, 2024
@fordN fordN requested a review from mangas March 4, 2024 16:44
mangas
mangas reviewed Mar 15, 2024
View reviewed changes
mangas
mangas reviewed Mar 15, 2024
View reviewed changes
mangas
mangas reviewed Mar 26, 2024
View reviewed changes
mangas
mangas approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@mangas mangas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments but overall LGTM

@incrypto32 incrypto32 force-pushed the krishna/topic-filtering branch 3 times, most recently from c796bca to 78cd08e Compare April 8, 2024 11:15
incrypto32 added 16 commits April 19, 2024 22:09
@incrypto32
chain/ethereum: Add topics to Event Handler in manifest
ffcb9f4
@incrypto32
test-store: Add topics parsing
c0ce7d0
@incrypto32
chain/ethereum: Add a new type EventSignatureWithTopics
d19495d
@incrypto32
chain/ethereum: Make topics a Vec in manifest
53b0c53
@incrypto32
chain/ethereum: Refactor EthGetLogsFilter and EventSignatureWithTopics
2bcef58
@incrypto32
chain/ethereum : Add events_with_topic_filters to EthereumLogFilter
c0bd0fb
@incrypto32
chain/ethereum : Wire logs_with_sigs to use topics
b210681
@incrypto32
chain/ethereum: Refactor log filter matching logic
d705595
@incrypto32
chain/ethereum: Add a matches helper for MappingEventHandler
5c8fe1f
@incrypto32
tests: Add integration tests for topic filters
0c7c74d
@incrypto32
chain/ethereum: fix topic filter when contract address is provided
f703152
@incrypto32
chain/ethereum: custom deserializer for topics which removes '0x' prefix
119a794
@incrypto32
tests/topic-filter: add more test cases
f360580
@incrypto32
graph, chain/ethereum: Add a new specVersion for topic filters
c20bf84
@incrypto32
chain/ethereum: clarify topic filters with comments and refactor matc…
468d3dd 
…hing logic
@incrypto32
graph, tests: Fix spec version mismatch for topic filters
75f33a2
@incrypto32 incrypto32 force-pushed the krishna/topic-filtering branch from 78cd08e to 75f33a2 Compare April 19, 2024 19:49
@incrypto32 incrypto32 merged commit 93b88d3 into master Apr 22, 2024
@incrypto32 incrypto32 deleted the krishna/topic-filtering branch April 22, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangas mangas mangas approved these changes

Assignees

@incrypto32 incrypto32

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Support indexed argument filtering
2 participants
@incrypto32 @mangas