store: Change which indexes are created to support aggregations #5286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
approved these changes
Apr 11, 2024
For cumulative aggregations, the code was confused about the table on which the index should be created. It needs to go on the aggregation table, not the underlying source table. These indexes have a significant impact on the performance of rollups, and having them on the wrong table makes rollups very slow. Fixes #5280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cumulative aggregations, the code was confused about the table on which the index should be created. It needs to go on the aggregation table, not the underlying source table. These indexes have a significant impact on the performance of rollups, and having them on the wrong table makes rollups very slow.
Fixes #5280