store: Check interface uniqueness in bulk #5293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
679abdc to
0a8f286
Compare
|
Rebased to latest master and fixed a test failure. The test |
zorancv
approved these changes
Apr 22, 2024
We used to run one query for each entity that was created or updated if it was of a type that implemented an interface. These single-entity queries can become quite time consuming during syncing. With this change, we check all the entities of a given type with a single query, so that uniqueness checking for interfaces causes as many queries as there are types (with new/updated entities) rather than as many as there are entities of such types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to run one query for each entity that was created or updated if it was of a type that implemented an interface. These single-entity queries can become quite time consuming during syncing.
With this change, we check all the entities of a given type with a single query, so that uniqueness checking for interfaces causes as many queries as there are types (with new/updated entities) rather than as many as there are entities of such types.