Use 'select by specific attributes' by default #5311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a43796b to
5910956
Compare
mangas
approved these changes
Apr 17, 2024
We make sure that the entity type for which we build the query is the entity type of the field(s) that get used. It's not possible to construct a query from GraphQL for which that is not true.
These tests now pass both with GRAPH_ENABLE_SELECT_BY_SPECIFIC_ATTRIBUTES set to true and to false
No functional change
If a query has an orderBy clause that mentions a field, we need to add it to the list of attributes we need to select. If it is a child attribute though, we do not, as that would try to access a column on the parent that doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these small fixes, a test run with the setting on and off did not produce any material differences in the query results. The only differences were in a few error messages that contained a debug dump of the query (where we now have a list of column names instead of
*)