Skip to content

firehose: Try to be more consistent in parsing to address #5360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2024
Merged

firehose: Try to be more consistent in parsing to address #5360

merged 1 commit into from
Apr 25, 2024

Conversation

leoyvens
Copy link
Collaborator

Use the same logic in both places where we parse it. An empty to is now assumed to be a contract creation.

sduchesneau
sduchesneau approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@sduchesneau sduchesneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! makes #5377 redundant :)

@leoyvens leoyvens merged commit 428f866 into master Apr 25, 2024
@leoyvens leoyvens deleted the leo/firehose-transaction-to-parsing branch April 25, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduchesneau sduchesneau sduchesneau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leoyvens @sduchesneau