Skip to content

store: Make sure transact_block_operations does not go backwards #5419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2024

Conversation

lutter
Copy link
Collaborator

@lutter lutter commented May 14, 2024

No description provided.

if let Some(block_ptr) = self.block_ptr.lock().unwrap().as_ref() {
if block_ptr_to.number <= block_ptr.number {
return Err(constraint_violation!(
"transact_block_operations called for block {} but its head is alread at {}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling 'already'.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops .. fixed

Copy link
Contributor

@zorancv zorancv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that reorgs are handled elsewhere seems a reasonable thing to do.

@lutter lutter force-pushed the lutter/nobacksies branch from 51d6f80 to 4d6f0ce Compare May 15, 2024 16:00
@lutter lutter force-pushed the lutter/nobacksies branch from 4d6f0ce to 5453480 Compare May 16, 2024 16:29
@lutter lutter merged commit 5453480 into master May 16, 2024
@lutter lutter deleted the lutter/nobacksies branch May 16, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants