Skip to content

graph, store: Improve error message when write fails #5420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2024

Conversation

lutter
Copy link
Collaborator

@lutter lutter commented May 15, 2024

When a write fails because Postgres is unhappy with it, e.g., because of an invalid block_range, it is very hard to understand what happened from the error message. This change improves that by including the entity type and the block at which the write failed as well as some other detail in the error message.

Copy link
Contributor

@zorancv zorancv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conversion of errors, so no risk of breaking changes.

@lutter lutter force-pushed the lutter/write-fail branch from 34ed608 to f8945ea Compare May 16, 2024 16:41
When a write fails because Postgres is unhappy with it, e.g., because of an
invalid block_range, it is very hard to understand what happened from the
error message. This change improves that by including the entity type and
the block at which the write failed as well as some other detail in the
error message.
@lutter lutter force-pushed the lutter/write-fail branch from f8945ea to bda1e36 Compare May 16, 2024 17:43
@lutter lutter merged commit bda1e36 into master May 16, 2024
@lutter lutter deleted the lutter/write-fail branch May 16, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants