-
Notifications
You must be signed in to change notification settings - Fork 1k
fix: resolves #5550 - make graphql value nullable #5551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@fordN and I had done some work over in the agent on this but found the root issue to be this field. Here is the indexer-agent PR graphprotocol/indexer#958 |
@dwerner we'd need to address the root cause here, the paused field should never be null, it should either be This is the part of the code where graph-node/store/postgres/src/primary.rs Line 632 in 0530ce1
To address the root cause we'll need to inspect the database if this is reproduced somewhere |
Closing this as a root cause fix is preferred |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Could you add comments to the node
and paused
field in the schema to say that a null
means that the deployment is not assigned to an indexing node?
26c8b34
to
35fce71
Compare
@lutter's pretty diagram. Thanks for helping me understand what's going on here. |
35fce71
to
df9b8aa
Compare
This PR fixes #5550 by making the
paused
field in the status graphql nullable, which matches the struct field ofOption<bool>
and allows the indexer-agent to handle theNone/null
case when appropriate.