Enable graft validation checks for debug #5584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
724ce94 to
8dce075
Compare
8dce075 to
8ec22b3
Compare
8ec22b3 to
386dbbf
Compare
|
@lutter @incrypto32 would appreciate a review of this PR. |
|
Interesting. This used to fail CI; do you have any idea where the reorg threshold is set to 0 when we run tests? |
|
Yep, this used to fail before. The reason for the change in behavior is that at the time the issue was opened, the And now, while running tests (which are typically in debug mode), the cfg!(debug_assertions) macro is being applied, and the reorg threshold is set to 0 by default. unless explicitly set by |
lutter
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5197
Fix graft validation checks
This will be good to go as we have
reorg_thresholdset to 0 on debug builds.graph-node/graph/src/env/mod.rs
Lines 238 to 241 in b0c8952