Graphman restart: Handle cases where multiple subgraph names reference a deployment ID #5674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It actually pauses and resumes the first of the two deployments. The second one is not accessible. Both names would point to the whichever happens to be first. If that's desired behaviour then is fine IMO. |
zorancv
approved these changes
Oct 17, 2024
|
In |
|
@lutter The code duplication will eventually be eliminated once more commands are added to Graphman GraphQL API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue that prevented
graphman restartfrom running if a deployment ID was referenced by multiple subgraph names. This PR fixes that.Closes #5670