Exclude full-text search columns from entity queries #5693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `tsvector` columns from `SELECT` clauses in entity queries - Filter out full-text search columns from the list of selected columns Full-text search columns (`tsvector` type) are used for indexing and efficient text searching, but they are not part of the entity's data model and are not meant to be directly queried or returned. This fixes a bug where trying to load a tsvector column fails, as diesel does not natively have tsvector support, and we don't explicitly handle the type in `relational::value::OidValue::from_sql`.
d52a468 to
017eebd
Compare
lutter
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsvectorcolumns fromSELECTclauses in entity queriesFull-text search columns (
tsvectortype) are used for indexing and efficient text searching, but they are not part of the entity's data model and are not meant to be directly queried or returned. This fixes a bug where trying to load a tsvector column fails, as diesel does not natively have tsvector support, and we don't explicitly handle the type inrelational::value::OidValue::from_sql.