-
Notifications
You must be signed in to change notification settings - Fork 1k
Remove Cosmos support #5833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Cosmos support #5833
Conversation
5e17429
to
424d3e7
Compare
Cargo.toml
Outdated
"store/test-store", | ||
"substreams/substreams-head-tracker", | ||
"substreams/substreams-trigger-filter", | ||
"substreams/trigger-filters", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cutting stuff is always nice!
|
||
#[tokio::test] | ||
async fn test_v4_u32_padding_ok() { | ||
u32_padding_ok(super::test::API_VERSION_0_0_4).await |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was padding only required for cosmos or some other network that was removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I think all these tests were solely for the derive macros that came in with Cosmos, but I'll check again before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked, and the tests I removed all depended on the derive macros that I also removed since they were only used by cosmos, i.e., they were testing that the derive macros behaved properly. I'll therefore merge this PR.
8e2ab9f
to
5b5726e
Compare
Cosmos support has been deprecated for a while and is not used anymore
Cosmos has been deprecated for a while and is not used anywhere anymore. Remove the support for it.