Skip to content

Remove Cosmos support #5833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Remove Cosmos support #5833

merged 3 commits into from
Mar 5, 2025

Conversation

lutter
Copy link
Collaborator

@lutter lutter commented Feb 18, 2025

Cosmos has been deprecated for a while and is not used anywhere anymore. Remove the support for it.

@lutter lutter changed the base branch from lutter/graphql-test to master February 18, 2025 19:31
@lutter lutter force-pushed the lutter/no-cosmos branch from 424d3e7 to 2576518 Compare March 4, 2025 15:39
Cargo.toml Outdated
"store/test-store",
"substreams/substreams-head-tracker",
"substreams/substreams-trigger-filter",
"substreams/trigger-filters",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@zorancv zorancv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cutting stuff is always nice!


#[tokio::test]
async fn test_v4_u32_padding_ok() {
u32_padding_ok(super::test::API_VERSION_0_0_4).await
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was padding only required for cosmos or some other network that was removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I think all these tests were solely for the derive macros that came in with Cosmos, but I'll check again before merging

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked, and the tests I removed all depended on the derive macros that I also removed since they were only used by cosmos, i.e., they were testing that the derive macros behaved properly. I'll therefore merge this PR.

@lutter lutter force-pushed the lutter/no-cosmos branch 2 times, most recently from 8e2ab9f to 5b5726e Compare March 5, 2025 11:48
@lutter lutter force-pushed the lutter/no-cosmos branch from 5b5726e to 1fcf5a5 Compare March 5, 2025 16:04
@lutter lutter merged commit 1fcf5a5 into master Mar 5, 2025
6 checks passed
@lutter lutter deleted the lutter/no-cosmos branch March 5, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants