Skip to content

store: Drop the vid sequence with 'cascade' #5968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Conversation

lutter
Copy link
Collaborator

@lutter lutter commented Apr 22, 2025

Since it is used for the default value, we get an error

  sequence sgdNNN.<table>_vid_seq membership in
  replication set default depends on sequence sgdNNN.<table>_vid_seq

That makes all pruning by rebuilding tables fail

@lutter lutter requested a review from zorancv April 22, 2025 21:55
Since it is used for the default value, we get an error

  sequence sgdNNN.<table>_vid_seq membership in
  replication set default depends on sequence sgdNNN.<table>_vid_seq

That makes all pruning by rebuilding tables fail
@lutter lutter force-pushed the lutter/prune-vid branch from ad51b2a to 2f47ed5 Compare April 22, 2025 21:55
@mangas
Copy link
Contributor

mangas commented Apr 23, 2025

Is there any way to add a regression test for this?

@lutter
Copy link
Collaborator Author

lutter commented Apr 23, 2025

Is there any way to add a regression test for this?

Notreally - this only happened if the database used pglogical and if the table had been added to a replication set. So pretty specific and sorta niche setup

@lutter lutter merged commit 2f47ed5 into master Apr 23, 2025
6 checks passed
@lutter lutter deleted the lutter/prune-vid branch April 24, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants