Allow caching of IPFS files in file system #6031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isum
approved these changes
May 22, 2025
|
@isum I reworked a good chunk of this, for a couple of reasons:
Sorry for troubling you again, but can you have another look at this PR? |
isum
reviewed
May 23, 2025
graph/src/ipfs/cache.rs
Outdated
| } | ||
|
|
||
| fn key(path: &ContentPath) -> String { | ||
| format!("ipfs:{}", path.cid()) |
There was a problem hiding this comment.
This ensures that we generate the correct key for requests of files within IPFS directories
Suggested change
| format!("ipfs:{}", path.cid()) | |
| format!("ipfs:{path}") |
There was a problem hiding this comment.
Aah .. yes! Nice catch!
graph/src/ipfs/cache.rs
Outdated
| Cache::Disk { store } => { | ||
| let log_err = |e: &object_store::Error| log_object_store_err(logger, e, false); | ||
|
|
||
| let path = Path::from(path.cid().to_string()); |
There was a problem hiding this comment.
This is necessary to ensure that we retrieve the correct data
Suggested change
| let path = Path::from(path.cid().to_string()); | |
| let path = Path::from(path.to_string()); |
graph/src/ipfs/cache.rs
Outdated
| } | ||
| Cache::Disk { store } => { | ||
| let log_err = |e: &object_store::Error| log_object_store_err(logger, e, true); | ||
| let path = Path::from(path.cid().to_string()); |
There was a problem hiding this comment.
This is necessary to ensure that we cache the correct data
Suggested change
| let path = Path::from(path.cid().to_string()); | |
| let path = Path::from(path.to_string()); |
Get the settings for CachingClient from the environment
Since the IpsClient is now responsible for caching, we shouldn't also cache in IpfsResolver
isum
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a variable
GRAPH_IPFS_CACHE_LOCATION, which, when set, needs to point at a directory writable bygraph-node. All files thatgraph-nodewill fetch from IPFS will be cached in that directory so that subsequent requests to fetch these files, e.g., after a restart, will use those cached files rather than issuing another IPFS request.Caching files has obvious security implications in that it is possible to modify files in the cache, and thereby change a subgraph. In other words, the cache needs to be in a trusted location with restricted access.