Complete level fetching when data loading finishes #2787
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key points: graphql.execution.AsyncExecutionStrategy.execute - combine execution result with fields value hook completion graphql.execution.instrumentation.dataloader.FieldLevelTrackingApproach.dispatch - return completable future
Key points: graphql.execution.ExecutionStrategy.fetchField - combine execution result with fields value hook completion
|
Closing because its old and in conlfict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to solve a problem described here
graphql-java/java-dataloader#54
The general idea is that data loader registry can return a completable future as a result of
public CompletableFuture<Integer> dispatch()call. This future can be used by graphql-java to reliably identify level fetching completion.The current change is using the code from this PR in data loader library: graphql-java/java-dataloader#111