This introduces an input interceptor #3188

bbakerman · 2023-04-15T04:27:32Z

This allows input values to be observed and in theory changed before being co-erced

bbakerman · 2023-04-15T04:28:49Z

src/main/java/graphql/execution/values/InputInterceptor.java

+    Object intercept(@Nullable Object value,
+                     @NotNull GraphQLInputType graphQLType,
+                     @NotNull GraphQLContext graphqlContext,
+                     @NotNull Locale locale);


I didn't use a FxxxEnvironment pattern here for 2 reasons

speed - no allocation needed

and its not API proper - so extension over time is less of a problem

bbakerman · 2023-04-15T04:32:54Z

src/main/java/graphql/execution/ValuesResolver.java

@@ -4,6 +4,7 @@
 import graphql.GraphQLContext;
 import graphql.Internal;
 import graphql.collect.ImmutableKit;
+import graphql.execution.values.InputInterceptor;


There is a LOT of reformatting going on here.

This class AND ValuesResolverCoercion are a mess of inter call dependency

I found it really hard to navigate what method is being called and so on.

So I made the code multi line in parameter terms to help make it more readable

What you will see it InputInterceptor being passed around everywhere. Some of the code (literal coercing say) don't need it BUT because they can in theory go into value coercion code, it needs to be put in place

Rather than refactor these two classes - I just passed it around everywhere so that it asked for once and then used. For performance reasons I do NOT do a graphqlContext.get() at the inner method since I could do that per time its called. Rather I asked for it once on the outer layers and then pass it everywhere.

bbakerman · 2023-04-15T04:33:45Z

src/main/java/graphql/execution/ValuesResolver.java

+                variableDefinitions,
+                rawVariables,
+                graphqlContext,
+                locale);
    }


See multi line parameters with extra inputInterceptor passed in.

bbakerman · 2023-04-15T04:35:41Z

src/main/java/graphql/execution/ValuesResolverConversion.java

+            GraphQLInputType inputType,
+            GraphQLContext graphqlContext,
+            Locale locale
+    ) {


GraphQLType type was always wrong. Ths is ALWAYS input types - always

We cast at certain places to treat it as a input type and some times we just do instanceof - BUT it should have always been a GraphQLInputType and now it is

bbakerman · 2023-04-15T04:42:10Z

src/main/java/graphql/execution/ValuesResolverConversion.java

            if (returnValue == null) {
                throw new NonNullableValueCoercedAsNullException(graphQLType);
            }
            return returnValue;
        }
-


PSSSSSTT! DOWN HERE!!

This is the main change. During variable coercion (and only variables - not literals) the callback is made if present BEFORE the value is presented to the scalar / enum coercions

So you can see what is coming in raw and possible change it or just log it say if its unexpected.

You CANT intercept the value AFTER its been co-erced. I didnt add that capability because I don't see a need for it

dondonz · 2023-04-17T00:41:15Z

src/main/java/graphql/execution/values/InputInterceptor.java

+     */
+    Object intercept(@Nullable Object value,
+                     @NotNull GraphQLInputType graphQLType,
+                     @NotNull GraphQLContext graphqlContext,


Hyper nit: the capitalisation of QL is different in these two parameters (I understand it's different throughout this file)

jbellenger · 2023-04-24T16:34:06Z

I'm looking forward to trying this out!

This introduces an input interceptor

66f2829

bbakerman added this to the 2023 July milestone Apr 15, 2023

bbakerman commented Apr 15, 2023

View reviewed changes

Tweak code

6c69c93

bbakerman commented Apr 15, 2023

View reviewed changes

dondonz reviewed Apr 17, 2023

View reviewed changes

dondonz approved these changes Apr 17, 2023

View reviewed changes

dondonz mentioned this pull request Apr 17, 2023

Adding Entry Point for custom coercion on standard scalars #3145

Closed

andimarek mentioned this pull request Apr 18, 2023

Revert stricter scalar parseValue coercion #3186

Merged

dondonz mentioned this pull request Apr 18, 2023

Stricter parseValue coercion for built-in scalars #3191

Closed

bbakerman added this pull request to the merge queue Apr 25, 2023

Merged via the queue into master with commit 8ccfa89 Apr 25, 2023

dondonz mentioned this pull request Apr 1, 2024

Stricter parseValue coercion for String, Int, Float, Boolean #3553

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

This introduces an input interceptor #3188

This introduces an input interceptor #3188

bbakerman commented Apr 15, 2023

bbakerman Apr 15, 2023 •

edited

Loading

bbakerman Apr 15, 2023

bbakerman Apr 15, 2023

bbakerman Apr 15, 2023

bbakerman Apr 15, 2023

dondonz Apr 17, 2023 •

edited

Loading

jbellenger commented Apr 24, 2023

This introduces an input interceptor #3188

This introduces an input interceptor #3188

Conversation

bbakerman commented Apr 15, 2023

bbakerman Apr 15, 2023 • edited Loading

Choose a reason for hiding this comment

bbakerman Apr 15, 2023

Choose a reason for hiding this comment

bbakerman Apr 15, 2023

Choose a reason for hiding this comment

bbakerman Apr 15, 2023

Choose a reason for hiding this comment

bbakerman Apr 15, 2023

Choose a reason for hiding this comment

dondonz Apr 17, 2023 • edited Loading

Choose a reason for hiding this comment

jbellenger commented Apr 24, 2023

bbakerman Apr 15, 2023 •

edited

Loading

dondonz Apr 17, 2023 •

edited

Loading