Skip to content

@oneOf handles non-null inputs #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2023
Merged

@oneOf handles non-null inputs #3353

merged 1 commit into from
Oct 22, 2023

Conversation

felipe-gdr
Copy link
Member

@felipe-gdr felipe-gdr commented Oct 20, 2023 •
edited
Loading

Non-null inputs are not going through @oneOf validation.

For example, the query bellow will not blow up, even though both fields under the oneOf type are being passed.

  # schema
  type Query {
    search(by: SearchInput!): String
  }
  input SearchInput @oneOf {
    name: String
    id: ID
  }

  # query
  query myQuery {
    search(by: {name: "Figaro", id: "1001"})
  }

@felipe-gdr felipe-gdr marked this pull request as draft October 20, 2023 05:20
@dondonz
Copy link
Member

dondonz commented Oct 20, 2023

Nice! Thanks

@dondonz dondonz added this to the 21.3 milestone Oct 22, 2023
@dondonz dondonz mentioned this pull request Oct 22, 2023
Merged
@felipe-gdr felipe-gdr marked this pull request as ready for review October 22, 2023 23:09
@dondonz dondonz added this pull request to the merge queue Oct 22, 2023
Merged via the queue into graphql-java:master with commit ea4414f Oct 22, 2023
@renovate renovate bot mentioned this pull request Aug 12, 2024
Open
1 task
@renovate renovate bot mentioned this pull request Aug 29, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dondonz dondonz dondonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
21.3
Development

Successfully merging this pull request may close these issues.
3 participants
@felipe-gdr @dondonz @felipe-gdr-atlassian