Add nullability annotations in DataFetchingEnvironment & sub-classes #3582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMHO this should not have been included in a minor version. Adding caused by this line: |
|
@juriad Lovely, the compiler now protects you against a possible NPE that you did not check in your code before, amazing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using Netflix' DGS with Kotlin, we ran into an issue where it was not immediately clear that
DataFetchingEnvironment.getLocalContextcan returnnull. After reading the documentation and the rest of theDataFetchingEnvironmentinterface, I noticed the lack of nullability annotations for Kotlin interoperability. However, I also saw that other classes in this project already use the Jetbrains annotations.In this PR I added nullability annotations to all methods of the
DataFetchingEnvironmentinterface that had mentions about nullability in their documentation. For patching the whole class I currently lack the overview of the bigger picture of this interface.I followed through on sub-classes that override these methods.