nested nullable list validation bugfix #3599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbellenger
commented
May 17, 2024
| "WEEKDAY" | '"somestr"' | format(EXPECTED_ENUM_MESSAGE, "StringValue") | ||
| "WEEKDAY" | 'SATURDAY' | format(MUST_BE_VALID_ENUM_VALUE_MESSAGE, "SATURDAY", "MONDAY,TUESDAY") | ||
| "UserInput" | '{ fieldNonNull: "str", fieldNonNull: "dupeKey" }' | format(DUPLICATED_KEYS_MESSAGE, "fieldNonNull") | ||
| "UserInput" | '{ fieldNonNull: "str", unknown: "field" }' | format(UNKNOWN_FIELDS_MESSAGE, "unknown", "UserInput") | ||
| "UserInput" | '{ fieldNonNull: "str", fieldArrayOfArray: ["ArrayInsteadOfArrayOfArray"] }' | format(EXPECTED_LIST_MESSAGE, "StringValue") |
There was a problem hiding this comment.
I'd appreciate a careful look at this change.
This test case, which provided a ["ArrayInsteadOfArrayOfArray"] value to a nested list [[String]] seemed to be incorrect because it assumed that a string value is not an allowed input for the inner list type. This seems explicitly allowed by this section of the spec.
bbakerman
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validating directive arguments that use nested list types, it looks like the validator does not allow nulls to be used in valid positions.
For example, given a type like
[[String!]], it rejects the value[null].After looking into this, it looks like #2001 added support for coercing singleton items into lists, but didn't handle null values. The relevant part of the spec is this:
This PR changes scalar-to-list coercion to allow null values in nested lists. A side effect of this is that the validation error
Argument value is X', expected a list value.will never be raised.