Start draining deferred results on subscription #3634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
commented
Jun 17, 2024
| * | ||
| * @return the publisher of deferred results | ||
| */ | ||
| public Publisher<DelayedIncrementalPartialResult> startDeferredCalls() { | ||
| drainIncrementalCalls(); |
There was a problem hiding this comment.
before this would start the deferred processing eagerly. It would begin to drain the deferred work before returning the publisher
bbakerman
commented
Jun 17, 2024
| private Supplier<SingleSubscriberPublisher<DelayedIncrementalPartialResult>> createPublisher() { | ||
| // this will be created once and once only - any extra calls to .get() will return the previously created | ||
| // singleton object | ||
| return new InterThreadMemoizedSupplier<>(() -> new SingleSubscriberPublisher<>(this::drainIncrementalCalls)); |
There was a problem hiding this comment.
now this creates a publisher that only calls drainIncrementalCalls when the publisher is subscribed to
felipe-gdr
approved these changes
Jun 17, 2024
| /** | ||
| * When this is called the deferred execution will begin | ||
| * When this is called the deferred execution will begin once the {@link Publisher} is subscribed |
There was a problem hiding this comment.
This comment turned out a little weird.
Maybe: "Returns a {@link Publisher} that, when subscribed to, will start emitting events containing incremental data."
felipe-gdr
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC - this should be what we are doding on defer to only start the publisher work on subscribe happening