Skip to content

Add missing NamedNode interface to OperationDefinition #3646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2024
Merged

Add missing NamedNode interface to OperationDefinition #3646

merged 1 commit into from
Jul 4, 2024

Conversation

dondonz
Copy link
Member

@dondonz dondonz commented Jun 26, 2024

Thanks to @gnawf for finding this! OperationDefinition has a getName method but it was missing the NamedNode interface.

I double checked everything else inside graphql.language, this is the only class that was missing NamedNode.

@dondonz dondonz added this pull request to the merge queue Jul 4, 2024
Merged via the queue into master with commit 1b76500 Jul 4, 2024
1 check passed
@dondonz dondonz deleted the operation-definition-named branch July 4, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andimarek andimarek andimarek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22.2: non-breaking changes
Development

Successfully merging this pull request may close these issues.
2 participants
@dondonz @andimarek