This introduces a Traversal Options to allow skipping the coercing of field arguments #3651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#3648 was the driver for this change |
bbakerman
commented
Jun 30, 2024
| @@ -50,13 +51,20 @@ public class NodeVisitorWithTypeTracking extends NodeVisitorStub { | |||
| private final GraphQLSchema schema; | |||
| private final Map<String, FragmentDefinition> fragmentsByName; | |||
| private final ConditionalNodes conditionalNodes = new ConditionalNodes(); | |||
|
|
|||
| public NodeVisitorWithTypeTracking(QueryVisitor preOrderCallback, QueryVisitor postOrderCallback, Map<String, Object> variables, GraphQLSchema schema, Map<String, FragmentDefinition> fragmentsByName) { | |||
There was a problem hiding this comment.
This is public but marked as @internal
bbakerman
commented
Jun 30, 2024
| Locale.getDefault()); | ||
| } else { | ||
| argumentValues = Collections.emptyMap(); | ||
| } |
bbakerman
commented
Jun 30, 2024
| private final GraphQLCompositeType rootParentType; | ||
| private final QueryTraversalOptions options; |
There was a problem hiding this comment.
QueryTransformer also uses the NodeTracking code and hence this can apply here as well - why not
bbakerman
commented
Jun 30, 2024
|
|
||
| Map<Class<?>, Object> rootVars = new LinkedHashMap<>(); | ||
| rootVars.put(QueryTraversalContext.class, new QueryTraversalContext(rootParentType, null, null, GraphQLContext.getDefault())); | ||
|
|
||
| TraverserVisitor<Node> nodeTraverserVisitor = new TraverserVisitor<Node>() { | ||
| TraverserVisitor<Node> nodeTraverserVisitor = new TraverserVisitor<>() { |
There was a problem hiding this comment.
tiny fix up - not need for generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default is the old behaviour of coercing by default
But this can turned off via options
I used an options class so we can extend with further options in the future.