Enable batching on Mutations #3737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
commented
Nov 2, 2024
| @@ -228,7 +228,7 @@ private DataLoaderDispatchStrategy createDataLoaderDispatchStrategy(ExecutionCon | |||
| if (executionContext.getDataLoaderRegistry() == EMPTY_DATALOADER_REGISTRY || doNotAutomaticallyDispatchDataLoader) { | |||
| return DataLoaderDispatchStrategy.NO_OP; | |||
| } | |||
| if (executionStrategy instanceof AsyncExecutionStrategy) { | |||
| if (! executionContext.isSubscriptionOperation()) { | |||
There was a problem hiding this comment.
code under here then uses PerLevelDataLoaderDispatchStrategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThisPR for the #3711 issue where mutations dont allow DataLoader delayed dispatching (rather it dispatches ALWAYS)
Mutations run in serial and hence dispatch one field at a time. However the data loader dispatching code previoiusly assumed that all of the mutation top level fields would be dispatched at once and hence it waited for all to be dispatched before it dispatched the dataloaders.
This changes that so that it expects one field at a time and it resets the tracing callstack per mutation field