Skip to content

Remove SDLExtensionDefinition from InterfaceTypeDefinition #3739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2024
Merged

Remove SDLExtensionDefinition from InterfaceTypeDefinition #3739

merged 2 commits into from
Nov 7, 2024

Conversation

gnawf
Copy link
Contributor

@gnawf gnawf commented Nov 4, 2024

No description provided.

@andimarek
Copy link
Member

This is technically a breaking change I guess.

@dondonz dondonz added this to the 23.x breaking changes milestone Nov 6, 2024
@dondonz dondonz added the breaking change requires a new major version to be relased label Nov 6, 2024
dondonz
dondonz approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@dondonz dondonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this bug!

@dondonz dondonz added this pull request to the merge queue Nov 7, 2024
Merged via the queue into graphql-java:master with commit 23e11c4 Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dondonz dondonz dondonz approved these changes

Assignees
No one assigned
Labels
breaking change requires a new major version to be relased
Projects
None yet
Milestone
23.0 breaking changes
Development

Successfully merging this pull request may close these issues.
4 participants
@gnawf @andimarek @dondonz @dzhou-atlassian