Add test reporting to pull request workflow #3747
Conversation
On a build with failing tests it is currently hard to see exactly which test failed. We thus add a popular test reporter to publish JUnit test results so that they can easily be examined. As workflows need to be approved by the maintainer to run, we will only be able to confirm whether this works once the maintainer enables this themselves.
|
Thanks for this. This is a thorn in all gradle users side - perhaps even maven They both have a "report.html" which is bollocks because cloud build systems dont retain files by default - they really should provide a summary via System.out at the end of the run. Lets see if this works well - thanks for contributing |
|
Hmm not working |
We are hitting permissions errors so bumping this should rectify it.
|
I am not at all a GitHub expert - but perhaps we need to set up "write permissions or some such" I gather the reporter will write back on the PR maybe ?? |
It's not clear that we also need `actions: read` and `contents: read` - so let's add them in one by one.
It's not obvious why these are needed (from the documentation) but it's what the example gives, so let's provide this.
Working example found in `helm-charts graphql-java#254`.
Without this we get `Resource not accessible by integration`.
Not sure why it broke last time; let's try again to be doubly sure.
|
I suspect this will be more complex than anticipated, reading the documentation, the example I've been using explicitly does not take with public repositories that are forked (i.e. this one). The advised example is also not something I am after, either - it only exposes annotations after a merge has been completed (making this not suitable for my use case). I'm a little surprised - Bitbucket Pipelines handles this almost perfectly, but I'm struggling with this one. Might need to decline this one unless you can see something I'm missing. |
|
Although some of the features are only on merge, it still looks like it's better than what we have today for PRs. How about I create a non-forked branch? I'll give you commit credit though |
|
Another option, this GitHub Action will comment and annotate PRs: https://github.com/EnricoMi/publish-unit-test-result-action |
|
Thanks so much for giving this a try. Inspired by you, I put up this alternate PR, with the PR test summary view #3749 Thanks for approving 😄 |
On a build with failing tests it is currently hard to see exactly which test failed.
We thus add a popular test reporter to publish JUnit test results so that they can easily be examined.
As workflows need to be approved by the maintainer to run, we will only be able to confirm whether this works once the maintainer enables this themselves.