ResultPath: Check object type before casting to int #3765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
reviewed
Dec 4, 2024
| @@ -212,6 +212,13 @@ class ResultPathTest extends Specification { | |||
| path.toList() == ["a", "b"] | |||
| } | |||
|
|
|||
| def "pass any other object than string or int"(){ | |||
| when: | |||
| ResultPath.fromList(["a", "b", true]) | |||
There was a problem hiding this comment.
the graphql-java code itself would never use anything but a String or Integer - but I am happy to have this be more robust
bbakerman
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a more robust validation to the
ResultPath.fromListmethod. As you can pass any object toGraphqlErrorException.Builder.path, it can lead to a ClassCastException when casting directly toint. this happened to me lol.