Skip to content

Return a singleton from CoercedVariables.emptyVariables and RawVariables.emptyVariables #3801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2025
Merged

Return a singleton from CoercedVariables.emptyVariables and RawVariables.emptyVariables #3801

merged 1 commit into from
Jan 27, 2025

Conversation

kilink
Copy link
Contributor

@kilink kilink commented Jan 24, 2025 •
edited
Loading

Make CoercedVariables.emptyVariables() and RawVariables.emptyVariables() return an immutable singleton instance.

@kilink
Use a singleton for empty raw / coerced variables
3d533da 
Make CoercedVariables.emptyVariables() and RawVariables.emptyVariables() return an immutable singleton instance.
@kilink kilink force-pushed the coerced-variables-empty-singleton branch from 5b0c192 to 3d533da Compare January 24, 2025 19:50
@kilink kilink changed the title Return a singleton from CoercedVariables.emptyVariables Return a singleton from CoercedVariables.emptyVariables and RawVariables.emptyVariables Jan 24, 2025
dondonz
dondonz approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@dondonz dondonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks

@dondonz dondonz added the performance work that is primarily targeted as performance improvements label Jan 25, 2025
@dondonz dondonz added this to the 23.x breaking changes milestone Jan 25, 2025
@dondonz dondonz merged commit db35370 into graphql-java:master Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbakerman bbakerman bbakerman approved these changes

@dondonz dondonz dondonz approved these changes

Assignees
No one assigned
Labels
performance work that is primarily targeted as performance improvements
Projects
None yet
Milestone
23.0 breaking changes
Development

Successfully merging this pull request may close these issues.
3 participants
@kilink @bbakerman @dondonz