Skip to content

Avoid allocation / stream overhead in ValuesResolverConversion #3803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

Avoid allocation / stream overhead in ValuesResolverConversion #3803

merged 1 commit into from
Jan 28, 2025
+15 −12

Conversation

kilink
Copy link
Contributor

@kilink kilink commented Jan 28, 2025

Avoid the overhead of streams and extra copying incurred in externalValueToLiteralForList.

@kilink
Avoid allocation / stream overhead in ValuesResolverConversion
3b2d17d 
Avoid the overhead of streams and extra copying incurred in externalValueToLiteralForList.
dondonz
dondonz approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@dondonz dondonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dondonz dondonz added the performance work that is primarily targeted as performance improvements label Jan 28, 2025
@dondonz dondonz added this to the 23.x breaking changes milestone Jan 28, 2025
bbakerman
bbakerman approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@bbakerman bbakerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Once again good old .stream() hurts you at scale!

@bbakerman bbakerman merged commit bb863b9 into graphql-java:master Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbakerman bbakerman bbakerman approved these changes

@dondonz dondonz dondonz approved these changes

Assignees
No one assigned
Labels
performance work that is primarily targeted as performance improvements
Projects
None yet
Milestone
23.0 breaking changes
Development

Successfully merging this pull request may close these issues.
3 participants
@kilink @bbakerman @dondonz