Skip to content

Quiet flaky test (for now) #3823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2025
Merged

Quiet flaky test (for now) #3823

merged 2 commits into from
Feb 15, 2025

Conversation

dondonz
Copy link
Member

@dondonz dondonz commented Feb 15, 2025

This test has confused many PR authors over the past 2 months, it's a strangely flaky test that always passes on the 2nd try.

I estimate it fails less than 15% of the time but it's still very confusing, especially for first time contributors. This test is getting put in quarantine while we do more investigation.

@dondonz dondonz changed the title Quiet flaky test for now Quiet flaky test (for now) Feb 15, 2025
@dondonz dondonz added this to the 23.x breaking changes milestone Feb 15, 2025
Copy link
Contributor

github-actions bot commented Feb 15, 2025

Test Results

  306 files    306 suites   46s ⏱️
3 486 tests 3 480 ✅ 6 💤 0 ❌
3 575 runs  3 569 ✅ 6 💤 0 ❌

Results for commit 7f84526.

♻️ This comment has been updated with latest results.

@dondonz dondonz merged commit 2d740aa into master Feb 15, 2025
2 checks passed
@dondonz dondonz deleted the quiet-flaky-test branch February 15, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant