Skip to content

Enable DataLoader chaining (nesting) #3872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 56 commits into from
May 16, 2025
Merged

Enable DataLoader chaining (nesting) #3872

merged 56 commits into from
May 16, 2025

Conversation

andimarek
Copy link
Member

@andimarek andimarek commented Mar 30, 2025 •
edited
Loading

enabling scheduling of nested/chained DataLoader calls

@andimarek andimarek changed the title introducing of a special CompletableFuture Enable DataLoader nesting/chaining Mar 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 30, 2025 •
edited
Loading

Test Results

  315 files    315 suites   2m 26s ⏱️
3 647 tests 3 642 ✅ 5 💤 0 ❌
3 736 runs  3 731 ✅ 5 💤 0 ❌

Results for commit c9a3ff3.

♻️ This comment has been updated with latest results.

bbakerman
bbakerman reviewed Mar 30, 2025
View reviewed changes
@andimarek andimarek mentioned this pull request Mar 30, 2025
Closed
Hc747
Hc747 reviewed Apr 1, 2025
View reviewed changes
bbakerman
bbakerman reviewed May 1, 2025
View reviewed changes
bbakerman
bbakerman reviewed May 1, 2025
View reviewed changes
bbakerman
bbakerman reviewed May 1, 2025
View reviewed changes
bbakerman
bbakerman reviewed May 1, 2025
View reviewed changes
bbakerman
bbakerman reviewed May 1, 2025
View reviewed changes
bbakerman
bbakerman requested changes May 1, 2025
View reviewed changes
Copy link
Member

@bbakerman bbakerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change for tests

@andimarek andimarek merged commit c16cf96 into master May 16, 2025
2 of 3 checks passed
@andimarek andimarek changed the title Enable DataLoader nesting/chaining Enable DataLoader chaining (nesting) Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbakerman bbakerman bbakerman requested changes

+1 more reviewer

@Hc747 Hc747 Hc747 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
25.x breaking changes
Development

Successfully merging this pull request may close these issues.
4 participants
@andimarek @bbakerman @Hc747 @dondonz