Skip to content

JS like Batching #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

JS like Batching #3873

wants to merge 3 commits into from

Conversation

andimarek
Copy link
Member

This is a modified version of #3872

Probably the closest Java can get to the JS dataloader batching:

  • we track now if the engine is running in the ExecutionContext (regardless of thread)
  • a very small batch window of 0.1ms is started every time a new DataLoaderCF is created.
  • if the DatatLoaderCF encounters a running engine while trying to dispatch the time window resets to avoid dispatching while the engine is running

@github-actions GitHub Actions
Copy link
Contributor

Test Results

  312 files    312 suites   51s ⏱️
3 580 tests 3 573 ✅ 6 💤 1 ❌
3 669 runs  3 662 ✅ 6 💤 1 ❌

For more details on these failures, see this check.

Results for commit dc19532.

@andimarek andimarek closed this Apr 1, 2025
@dondonz dondonz removed this from the 25.x breaking changes milestone Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andimarek @dondonz