Skip to content

Specify nullness for some graphql.schema.idl classes #3895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Specify nullness for some graphql.schema.idl classes #3895

wants to merge 3 commits into from

Conversation

mk868
Copy link

@mk868 mk868 commented Apr 5, 2025

Related #3878

I applied @NullMarked on the classes:

  • graphql.Assert
  • graphql.schema.idl.FieldWiringEnvironment
  • graphql.schema.idl.InterfaceWiringEnvironment
  • graphql.schema.idl.ScalarInfo
  • graphql.schema.idl.ScalarWiringEnvironment
  • graphql.schema.idl.SchemaParser
  • graphql.schema.idl.TypeDefinitionRegistry
  • graphql.schema.idl.UnionWiringEnvironment
  • graphql.schema.idl.WiringEnvironment

bbakerman
bbakerman requested changes Apr 7, 2025
View reviewed changes
Copy link
Member

@bbakerman bbakerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets decide on the Assert nullness question and then move forward

@bbakerman
Copy link
Member

I am geenrally happy with this PR so thank you. Its just that Assert is a special case and I am not sure how to move forward on that

@mk868 mk868 requested a review from bbakerman April 7, 2025 15:37
@dondonz
Copy link
Member

dondonz commented Apr 12, 2025

Thanks for the pull request! I like your choice with Assert as well

dondonz
dondonz approved these changes Apr 19, 2025
View reviewed changes
Copy link
Member

@dondonz dondonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We are on Easter break, will come back to your PR after the holidays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dondonz dondonz dondonz approved these changes

@bbakerman bbakerman Awaiting requested review from bbakerman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
23.1 non-breaking changes and bugfixes
Development

Successfully merging this pull request may close these issues.
3 participants
@mk868 @bbakerman @dondonz