Skip to content

Cherry pick revert of susbcriptions include and skip rule from master #3919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Cherry pick revert of susbcriptions include and skip rule from master #3919

merged 1 commit into from
Apr 15, 2025

Conversation

dondonz
Copy link
Member

@dondonz dondonz commented Apr 15, 2025

Cherry picks the same revert on master, to prepare for release #3917

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025 •
edited
Loading

Test Results

  312 files   - 1    312 suites   - 1   55s ⏱️ -1s
3 581 tests  - 7  3 576 ✅  - 7  5 💤 ±0  0 ❌ ±0 
3 670 runs   - 7  3 665 ✅  - 7  5 💤 ±0  0 ❌ ±0 

Results for commit 18ac75c. ± Comparison against base commit 27b9def.

This pull request removes 210 and adds 181 tests. Note that renamed tests count towards both. 
	?
                __schema { types { fields { args { type { name fields { name }}}}}}
                __schema { types { fields { type { name fields { name }}}}}
                __schema { types { inputFields { type { inputFields { name }}}}}
                __schema { types { interfaces { fields { type { interfaces { name } } } } } }
                __schema { types { name} }
                __type(name : "t") { name }
                a1: __schema { types { name} }
                a1: __type(name : "t") { name }
                a2 :  __type(name : "t1") { name }
…

graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure23@557286ad delegate=graphql.AssertTest@27d57a2c owner=graphql.AssertTest@27d57a2c thisObject=graphql.AssertTest@27d57a2c resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure24@7e4d2287 delegate=graphql.AssertTest@27d57a2c owner=graphql.AssertTest@27d57a2c thisObject=graphql.AssertTest@27d57a2c resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure25@3f4b840d delegate=graphql.AssertTest@27d57a2c owner=graphql.AssertTest@27d57a2c thisObject=graphql.AssertTest@27d57a2c resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure20@20e6c4dc delegate=graphql.AssertTest@27d57a2c owner=graphql.AssertTest@27d57a2c thisObject=graphql.AssertTest@27d57a2c resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure21@60737b23 delegate=graphql.AssertTest@27d57a2c owner=graphql.AssertTest@27d57a2c thisObject=graphql.AssertTest@27d57a2c resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure22@4d2a1da3 delegate=graphql.AssertTest@27d57a2c owner=graphql.AssertTest@27d57a2c thisObject=graphql.AssertTest@27d57a2c resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure3@4d48bd85 delegate=graphql.AssertTest@27d57a2c owner=graphql.AssertTest@27d57a2c thisObject=graphql.AssertTest@27d57a2c resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure4@dca2615 delegate=graphql.AssertTest@27d57a2c owner=graphql.AssertTest@27d57a2c thisObject=graphql.AssertTest@27d57a2c resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure5@7772054c delegate=graphql.AssertTest@27d57a2c owner=graphql.AssertTest@27d57a2c thisObject=graphql.AssertTest@27d57a2c resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertNotNull with different number of error args with non null does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_6prov0_closure6@6f7e336b delegate=graphql.AssertTest@27d57a2c owner=graphql.AssertTest@27d57a2c thisObject=graphql.AssertTest@27d57a2c resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
…

♻️ This comment has been updated with latest results.

@dondonz dondonz merged commit 6ff6f7d into 23.x Apr 15, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dondonz