A generalised configuration mechanism #3945
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
commented
May 1, 2025
| * including some JVM wide settings and some per execution settings | ||
| * as well as experimental ones | ||
| */ | ||
| public class GraphQLConfiguration { |
There was a problem hiding this comment.
Other name suggestion GraphQlSettings and hence the name of GraphQl.configuration() would change
bbakerman
commented
May 1, 2025
| @@ -175,7 +175,7 @@ public static ParserOptions getDefaultSdlParserOptions() { | |||
| * | |||
| * This static can be set to true to allow the behavior of version 16.x or before. | |||
| * | |||
| * @param options - the new default JVM parser options for operation parsing | |||
| * @param options - the new default JVM parser options for SDL parsing | |||
There was a problem hiding this comment.
found a java doc mistake
Test Results 313 files 313 suites 53s ⏱️ Results for commit 2f9728e. ♻️ This comment has been updated with latest results. |
bbakerman
commented
May 1, 2025
| return INCREMENTAL_SUPPORT_CFG; | ||
| } | ||
|
|
||
| public static class ParserCfg { |
There was a problem hiding this comment.
parse config here is repeated - so sure you can go direct to ParserOptions and thats not too bad a name to discover
BUT
This makes it central and future ones can be here
…ntext wrapping mechanism
…ntext wrapping mechanism - renamed as extraordinary
…ntext wrapping mechanism - renamed as unusual
…ntext wrapping mechanism - renamed as config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discoverability of how to config special parts of graphql-java is low
This tries to centralise that by providing a simple DSL and a common place to set both JVM wide and execution specific configuration
This is currently
but it could be
or
but I kinda like how it comes off the
GraphQlobject for discoverability