Skip to content

OSGI - Make org.jspecify.* imports optional #3949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

schulm
Copy link

@schulm schulm commented May 5, 2025

Since org.specify import is not necessarily needed at runtime, can we make it optional?

@andimarek
Copy link
Member

@schulm sounds reasonable.

@dondonz @bbakerman thoughts?

@bbakerman
Copy link
Member

Yeah we should add this.

@bbakerman bbakerman self-requested a review May 6, 2025 00:38
Copy link
Member

@bbakerman bbakerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not many use OSGI any more but why not

@bbakerman bbakerman added this to the 24.0 milestone May 6, 2025
@bbakerman bbakerman merged commit 5f07138 into graphql-java:master May 6, 2025
1 check passed
@schulm
Copy link
Author

schulm commented May 6, 2025

@bbakerman Thanks, would you also have a look at graphql-java/java-dataloader#194

@schulm schulm mentioned this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants