Skip to content

Response factory as config #3950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2025
Merged

Response factory as config #3950

merged 3 commits into from
Jun 5, 2025

Conversation

bbakerman
Copy link
Member

This depends on #3945

But this removes the GraphQL aspect of ResponseMapFactory and makes it per context

@bbakerman bbakerman added this to the 24.0 milestone May 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2025 •
edited
Loading

Test Results

  318 files  ±0    318 suites  ±0   2m 32s ⏱️ +2s
4 678 tests +1  4 669 ✅ +1  9 💤 ±0  0 ❌ ±0 
4 767 runs  +1  4 758 ✅ +1  9 💤 ±0  0 ❌ ±0 

Results for commit 358c540. ± Comparison against base commit 2b26495.

This pull request removes 174 and adds 153 tests. Note that renamed tests count towards both. 
	?
                __schema { types { fields { args { type { name fields { name }}}}}}
                __schema { types { fields { type { name fields { name }}}}}
                __schema { types { inputFields { type { inputFields { name }}}}}
                __schema { types { interfaces { fields { type { interfaces { name } } } } } }
                __schema { types { name} }
                __type(name : "t") { name }
                a1: __schema { types { name} }
                a1: __type(name : "t") { name }
                a2 :  __type(name : "t1") { name }
…

graphql.DataFetcherTest ‑ get Boolean property value [fetcher: <graphql.schema.PropertyDataFetcher@6ff0b1cc propertyName=booleanField function=null>, #0]
graphql.DataFetcherTest ‑ get Boolean property value [fetcher: <graphql.schema.SingletonPropertyDataFetcher@2262d6d5>, #1]
graphql.DataFetcherTest ‑ get Boolean property value with get [fetcher: <graphql.schema.PropertyDataFetcher@3ba3d4b6 propertyName=booleanFieldWithGet function=null>, #0]
graphql.DataFetcherTest ‑ get Boolean property value with get [fetcher: <graphql.schema.SingletonPropertyDataFetcher@2262d6d5>, #1]
graphql.DataFetcherTest ‑ get property value [fetcher: <graphql.schema.PropertyDataFetcher@642857e0 propertyName=property function=null>, #0]
graphql.DataFetcherTest ‑ get property value [fetcher: <graphql.schema.SingletonPropertyDataFetcher@2262d6d5>, #1]
graphql.DataFetcherTest ‑ get public field value as property [fetcher: <graphql.schema.PropertyDataFetcher@6088451e propertyName=publicField function=null>, #0]
graphql.DataFetcherTest ‑ get public field value as property [fetcher: <graphql.schema.SingletonPropertyDataFetcher@2262d6d5>, #1]
graphql.ScalarsBooleanTest ‑ parseValue throws exception for invalid input <java.lang.Object@551b0266>
graphql.ScalarsBooleanTest ‑ serialize throws exception for invalid input <java.lang.Object@255d8982>
…

♻️ This comment has been updated with latest results.

@dondonz dondonz modified the milestones: 24.0, 25.x breaking changes May 12, 2025
@bbakerman
Merge remote-tracking branch 'origin/master' into response-factory-as…
358c540 
…-config

# Conflicts:
#	src/main/java/graphql/GraphQLUnusualConfiguration.java
#	src/main/java/graphql/execution/Execution.java
#	src/test/groovy/graphql/config/GraphQLUnusualConfigurationTest.groovy
@bbakerman bbakerman merged commit 8218dd0 into master Jun 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
25.x breaking changes
Development

Successfully merging this pull request may close these issues.
2 participants
@bbakerman @dondonz