fix case when a fragment is deferred and non deferred at the same time #3953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipe-gdr
reviewed
May 9, 2025
| initialResult.toSpecification() == [ | ||
| data: [post: [summary: "A summary", text: "The full text"]] | ||
| ] | ||
|
|
There was a problem hiding this comment.
can you assert on the incremental payloads as well?
There was a problem hiding this comment.
What do you want to assert exactly? there is no incremental result in this case: is that correct?
Should we add another test case with some incremental result?
There was a problem hiding this comment.
You're right. I misread your test scenario.
In that case, do we need to assert that there aren't incremental payloads? Like, initialResult is not IncrementalExecutionResult?
And perhaps change the name of the variable, initialResult gives the impression that this is an incremental result.
Test Results 314 files 314 suites 53s ⏱️ Results for commit 79f3aa5. |
bbakerman
approved these changes
May 9, 2025
felipe-gdr
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.