Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: graphql-java/java-dataloader
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.1.4
Choose a base ref
...
head repository: graphql-java/java-dataloader
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.2.0
Choose a head ref
  • 6 commits
  • 14 files changed
  • 2 contributors

Commits on Jul 10, 2022

  1. Add context objects to StatisticsCollector methods

    The `StatisticsCollector` interface is useful for gathering basic
    metrics about data loaders, but is limited in that we are unable to pass
    in any sort of context (key or call). This would allow us to obtain more
    insightful metrics (for example, we would be able to break down metrics
    based on the GraphQL operation name).
    
    To this end, we add `*StatisticsContext` objects to each
    `StatisticsCollector` method; we provide distinct implementations for
    each one rather than a generic catch-all so that we may evolve them
    independently as needed.
    AlexandreCarlton committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    0558d3d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8ca99cc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5983e10 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. Copy across valueCache in DataLoaderOptions copy constructor

    This looks like an accidental omission, so we include this along with
    all the other variables inside this class.
    AlexandreCarlton committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    fc2bfaa View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2022

  1. Merge pull request #120 from AlexandreCarlton/add-statistics-context-…

    …to-collectors
    
    Add context objects to StatisticsCollector methods
    bbakerman authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    7a59ead View commit details
    Browse the repository at this point in the history
  2. Merge pull request #121 from AlexandreCarlton/copy-over-value-cache-i…

    …n-options
    
    Copy across valueCache in DataLoaderOptions copy constructor
    bbakerman authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    59b26b8 View commit details
    Browse the repository at this point in the history
Loading