Stack traces are captured when an exception is created. Throwing the same instance will result in incorrect traces. Look at JVM classes, e.g. UnmodifiableCollection#add.
Exceptions are supposed to be created in exceptional cases, not in hot paths.

Or am I misunderstanding the situation? 😶

will result in incorrect traces [...] Or am I misunderstanding the situation?

@kaqqao No, you aren't

The thing is that the exception is discarded right after checking if the key is cached:

Thus it does not matter.

Thanks for this PR - this is important. It was not meant to be allocating any memory

I think we can take this further.

I created #109 so that it can short circuit out of the value cache which makes it faster by default

No. #109 looks good, glad my profiling helped bring this issue to light.

I will close this PR as it is no longer necessary.