Making DataLoaderOptions immutable #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bbakerman merged 1 commit into master from make-dataloader-options-immutable

Feb 21, 2025

Member

bbakerman commented Jan 30, 2025

DataLoaderOptions was not immutable and this can lead to bugs now that we have DataLoader + builders + transformation


          Making DataLoaderOptions immutable

a65cf34

dondonz approved these changes

View reviewed changes

src/main/java/org/dataloader/DataLoaderOptions.java

                       environmentProvider = NULL_PROVIDER;
-                      valueCacheOptions = ValueCacheOptions.newOptions();
+                      valueCacheOptions = DEFAULT_VALUE_CACHE_OPTIONS;

Member

dondonz Feb 1, 2025

Nice

dondonz added the breaking change label

andimarek approved these changes

View reviewed changes

bbakerman merged commit cf79290 into master

1 check passed

dondonz added this to the 4.0.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change