More explicit nullable annotations on BatchLoader interfaces #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2025
bbakerman
commented
Jun 25, 2025
| } | ||
|
|
||
| private boolean isMappedPublisher() { | ||
| return batchLoadFunction instanceof MappedBatchPublisher; | ||
| return batchLoadFunction instanceof MappedBatchPublisher || batchLoadFunction instanceof MappedBatchPublisherWithContext; | ||
| } |
There was a problem hiding this comment.
This fixes needs to be done again with more systemic testing MappedBatchPublisherWithContext and BatchPublisherWithContext dont work right now it seems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
V extends @Nullable Objecton the batch loader interfaces to indicate that the values can be null.