Skip to content

Update context and root executor options #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2020
Merged

Update context and root executor options #74

merged 4 commits into from
Feb 25, 2020

Conversation

KingDarBoja
Copy link
Contributor

@KingDarBoja KingDarBoja commented Feb 14, 2020 •
edited
Loading

📦 Enhancement

Fixes #70 and Fixes #71

  • Bump graphl-core minimum version to 2.3 (was 2.1).
  • Provide context_value and root_value to executor options (was context and root).

@KingDarBoja KingDarBoja requested review from jkimbo and Cito February 14, 2020 00:36
@coveralls
Copy link

coveralls commented Feb 14, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 93.548% when pulling ddfe787 on KingDarBoja:enhancement/update-context-root-values into 0137ca1 on graphql-python:master.

jkimbo
jkimbo approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jkimbo jkimbo merged commit d29cc6f into graphql-python:master Feb 25, 2020
@KingDarBoja KingDarBoja deleted the enhancement/update-context-root-values branch February 25, 2020 14:14
@rzane
Copy link

rzane commented Apr 25, 2020

Would it be possible to publish a new version that includes this change? These warnings are spamming my console 😄

@checor
Copy link

checor commented Jun 9, 2020

An update would be surely appreciate. But I can understand if this isn't a priority or worthy.

@silpol
Copy link

silpol commented Nov 26, 2020

any chance to get it included into PyPI-published release? thank you

@KingDarBoja
Copy link
Contributor Author

KingDarBoja commented Nov 26, 2020 •
edited
Loading

These changes are included on latest beta version of graphql-server, checkout https://github.com/graphql-python/graphql-server/blob/master/docs/flask.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkimbo jkimbo jkimbo approved these changes

@Cito Cito Awaiting requested review from Cito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@KingDarBoja @coveralls @rzane @checor @silpol @jkimbo