Skip to content

Merge aiohttp-graphql #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

KingDarBoja
Copy link
Contributor

References #34, this PR merges aiohttp-graphql library into graphql-server-core.

To install the integration with aiohttp, run the below command on your terminal.
pip install graphql-server-core[aiohttp].

This should be rebased after #38 gets merged in order to solve the failing tests at graphql-server-core files.

@KingDarBoja KingDarBoja added the type: feature A new feature label May 17, 2020
@KingDarBoja KingDarBoja requested a review from jkimbo May 17, 2020 00:15
@KingDarBoja KingDarBoja self-assigned this May 17, 2020
@KingDarBoja KingDarBoja requested a review from Cito June 2, 2020 23:07
jkimbo
jkimbo previously approved these changes Jun 6, 2020
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There is definitely lots of code that could be shared between the different framework implementations but this is good for now.

@KingDarBoja KingDarBoja requested a review from jkimbo June 6, 2020 18:07
@KingDarBoja KingDarBoja merged commit 8e2f147 into graphql-python:master Jun 10, 2020
@KingDarBoja KingDarBoja deleted the merge-aiohttp-graphql branch June 10, 2020 17:25
@KingDarBoja KingDarBoja added this to the GraphQL-Server (V3) milestone Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants